Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the UI test files #648

Merged

Conversation

shreyakhajanchi
Copy link
Collaborator

Updated test files for all the UI components for successful run.

Command executed:
ng test

@manitgupta
Copy link
Member

Before we get into the details of the PR, can we add the following -

  1. Can you publish the current % coverage, with the UI unit tests added?
  2. Can we update github actions to run the UI unit tests as part of the PR processes? Looks like the UI unit test can be step in the code-coverage-check action.

.github/workflows/ui-test-coverage.yaml Outdated Show resolved Hide resolved
ui/angular.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #648 (f38a830) into master (1d29000) will decrease coverage by 5.86%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
- Coverage   54.25%   48.39%   -5.86%     
==========================================
  Files          65      117      +52     
  Lines       12355    15780    +3425     
  Branches        0      468     +468     
==========================================
+ Hits         6703     7637     +934     
- Misses       5185     7657    +2472     
- Partials      467      486      +19     
Components Coverage Δ
backend-apis 43.54% <ø> (ø)
backend-library 60.21% <ø> (ø)
cli 0.00% <ø> (ø)
frontend 27.27% <100.00%> (∅)
Files Coverage Δ
...ponents/add-new-column/add-new-column.component.ts 57.14% <100.00%> (ø)

... and 51 files with indirect coverage changes

Copy link
Collaborator

@bharadwaj-aditya bharadwaj-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreyakhajanchi shreyakhajanchi merged commit b8e56a6 into GoogleCloudPlatform:master Nov 22, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants