Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross-project IAM binding support #955

Merged
merged 40 commits into from
Jul 19, 2021

Conversation

pasha-gh
Copy link
Contributor

@pasha-gh pasha-gh commented Jul 13, 2021

Supports cross-project IAM binding support for the following resources:

  • storage_bucket
  • project
  • organization
  • folder

Closes #828

@MartinPetkov
Copy link
Contributor

/gcbrun

examples/tfengine/generated/team/cicd/triggers.tf Outdated Show resolved Hide resolved
examples/tfengine/modules/team.hcl Outdated Show resolved Hide resolved
templates/tfengine/recipes/project.hcl Outdated Show resolved Hide resolved
templates/tfengine/recipes/iam_bindings.hcl Outdated Show resolved Hide resolved
examples/tfengine/iam_bindings.hcl Outdated Show resolved Hide resolved
templates/tfengine/components/iam_bindings/main.tf Outdated Show resolved Hide resolved
templates/tfengine/components/iam_bindings/main.tf Outdated Show resolved Hide resolved
docs/tfengine/schemas/project.md Outdated Show resolved Hide resolved
templates/tfengine/components/iam_bindings/main.tf Outdated Show resolved Hide resolved
templates/tfengine/recipes/iam_bindings.hcl Outdated Show resolved Hide resolved
templates/tfengine/recipes/iam_bindings.hcl Outdated Show resolved Hide resolved
examples/tfengine/modules/foundation.hcl Outdated Show resolved Hide resolved
examples/tfengine/iam_bindings.hcl Outdated Show resolved Hide resolved
templates/tfengine/components/iam_bindings/main.tf Outdated Show resolved Hide resolved
templates/tfengine/components/iam_bindings/main.tf Outdated Show resolved Hide resolved
@MartinPetkov
Copy link
Contributor

/gcbrun

@pasha-gh
Copy link
Contributor Author

/gcbrun

Copy link
Contributor

@MartinPetkov MartinPetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd wait for @xingao267 too

Copy link
Contributor

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@xingao267
Copy link
Member

Few final comments. Almost there! Thanks @pasha-gh

@pasha-gh
Copy link
Contributor Author

/gcbrun

@pasha-gh pasha-gh requested a review from xingao267 July 19, 2021 12:48
@xingao267
Copy link
Member

@pasha-gh LGTM, thanks! When you merge, clean up the commit messages for intermediate commits, as by default, it will include all commit message for all your commits in this PR.

@pasha-gh pasha-gh closed this Jul 19, 2021
@pasha-gh pasha-gh reopened this Jul 19, 2021
@pasha-gh
Copy link
Contributor Author

/gcbrun

@pasha-gh pasha-gh merged commit 52d8fd6 into GoogleCloudPlatform:master Jul 19, 2021
ernestognw pushed a commit that referenced this pull request Jul 20, 2021
* Add recipe for cross-project IAM permissions

Add cross-project IAM permission support for the following resources:
storage buckets
projects
organizations
folders
ernestognw pushed a commit that referenced this pull request Jul 20, 2021
* Add recipe for cross-project IAM permissions

Add cross-project IAM permission support for the following resources:
storage buckets
projects
organizations
folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Managing cross project service account permissions (IAM)
4 participants