Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct lastUpdatedPartitionConfig as optional #1194

Merged
merged 19 commits into from
Jan 17, 2024
Merged

correct lastUpdatedPartitionConfig as optional #1194

merged 19 commits into from
Jan 17, 2024

Conversation

JosieLi-Google
Copy link
Collaborator

No description provided.

@JosieLi-Google
Copy link
Collaborator Author

/gcbrun

Copy link
Collaborator

@yeweidaniel yeweidaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test it by pointing your local scripts to your own fork's commit, then running tfengine with and without last_updated_partition_config?

@JosieLi-Google
Copy link
Collaborator Author

/gcbrun

@yeweidaniel yeweidaniel merged commit 9564401 into master Jan 17, 2024
5 checks passed
@yeweidaniel yeweidaniel deleted the yifangli10 branch January 17, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants