-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENUM type should be integer #3
base: master
Are you sure you want to change the base?
Conversation
When running on protobuf examples, it was failing to create the schema because enums are integers, not strings. With this change, I was able to create the schema properly.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Thank you for your contribution. Although I understand that there are such use-cases which need to marshal enums into integers, I would like to accept this PR in a bit different way. This is because of several reasons:
|
Michael -- we're looking to start maintaining this repo again. Unless you say otherwise, I'm going to assume this pullrequest should be closed. |
Is this repo now considered actively maintained? |
Judah - to be clear, there's no allocated budget in Google to maintain this repo. But I'm doing a bit here and there (as necessary) as part of my day job to review PRs, make fixes, etc. It's on a best effort basis. As always with open source, you're free to fork the repo (as chuhlomin did). Mark |
Updated Readme. Added description and examples of using PolicyTags
When running on protobuf examples, it was failing to create the schema because enums are integers, not strings. With this change, I was able to create the schema properly.