Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENUM type should be integer #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ENUM type should be integer #3

wants to merge 1 commit into from

Conversation

merdosy
Copy link

@merdosy merdosy commented Jun 2, 2017

When running on protobuf examples, it was failing to create the schema because enums are integers, not strings. With this change, I was able to create the schema properly.

When running on protobuf examples, it was failing to create the schema because enums are integers, not strings. With this change, I was able to create the schema properly.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@merdosy
Copy link
Author

merdosy commented Nov 19, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@yugui
Copy link
Collaborator

yugui commented Dec 7, 2017

Thank you for your contribution.

Although I understand that there are such use-cases which need to marshal enums into integers, I would like to accept this PR in a bit different way.
So how about adding a runtime option to change the behavior of the plugin? Also, if you want to statically keep the type mapping in your proto file, you can use #6.

This is because of several reasons:

@mescanne
Copy link
Collaborator

Michael -- we're looking to start maintaining this repo again. Unless you say otherwise, I'm going to assume this pullrequest should be closed.

@judahrand
Copy link

Michael -- we're looking to start maintaining this repo again. Unless you say otherwise, I'm going to assume this pullrequest should be closed.

Is this repo now considered actively maintained?

@mescanne
Copy link
Collaborator

Michael -- we're looking to start maintaining this repo again. Unless you say otherwise, I'm going to assume this pullrequest should be closed.

Is this repo now considered actively maintained?

Judah - to be clear, there's no allocated budget in Google to maintain this repo. But I'm doing a bit here and there (as necessary) as part of my day job to review PRs, make fixes, etc. It's on a best effort basis.

As always with open source, you're free to fork the repo (as chuhlomin did).

Mark

mescanne pushed a commit that referenced this pull request Feb 18, 2022
Updated Readme. Added description and examples of using PolicyTags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants