test(promqle2etest): add vanilla Prometheus remote write 2.0 to GCM test case#334
Draft
bwplotka wants to merge 2 commits into
Draft
test(promqle2etest): add vanilla Prometheus remote write 2.0 to GCM test case#334bwplotka wants to merge 2 commits into
bwplotka wants to merge 2 commits into
Conversation
…est case Add PrometheusRemoteWriteGCMBackend (`prom-prw-gcm`) to test vanilla Prometheus Remote Write 2.0 ingestion against GCM. Configure required feature flags (`--enable-feature=st-synthesis`, etc.) and remote_write settings (`google_iam`, `write_relabel_configs`, `convert_classic_histograms_to_nhcb`). TAG=agy CONV=e18940f4-6a0d-4ae6-b6cd-5bfcc9700aa5
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new test backend, PrometheusRemoteWriteGCMBackend, which configures a vanilla Prometheus instance to push metrics to Google Cloud Monitoring (GCM) via the Prometheus Remote Write 2.0 protocol. This backend is integrated into the existing GCM acceptance tests to validate its behavior. A review comment identifies an issue in the Prometheus write relabel configuration where labeldrop is incorrectly configured with source_labels instead of regex, which could result in dropping all labels.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PrometheusRemoteWriteGCMBackend (
prom-prw-gcm) to test vanilla Prometheus Remote Write 2.0 ingestion against GCM. Configure required feature flags (--enable-feature=st-synthesis, etc.) and remote_write settings (google_iam,write_relabel_configs,convert_classic_histograms_to_nhcb).TAG=agy
CONV=e18940f4-6a0d-4ae6-b6cd-5bfcc9700aa5