Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

healthchecks: Handle no such host from Network Check and show MetaApiConnErr as WARNING. #1631

Closed

Conversation

franciscovalentecastro
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro commented Feb 26, 2024

When verifying connection to endpoints during Network Check execution (see network_check.go), if the endpoint doesn't exist it shows the following error (see #1630) :

[Network Check] Result: ERROR, Detail: Get "http://metadata.google.internal/": dial tcp *:

This PR does the following changes :

  • Handle no such host from Network Check and present FAILURE (log and monitoring api endpoints) or WARNING (not required endpoints for Ops Agent execution) when appropiate.
  • Show MetaApiConnErr as WARNING (not fatal error).

Description

Related issue

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@igorpeshansky igorpeshansky changed the title healthchekcs: Handle no such host from Network Check and show MetaApiConnErr as WARNING. healthchecks: Handle no such host from Network Check and show MetaApiConnErr as WARNING. Feb 26, 2024
Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 17, 2024
Copy link

github-actions bot commented Dec 1, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant