Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update otel submodule to pick up DCGM receiver change #1370

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

LujieDuan
Copy link
Contributor

@LujieDuan LujieDuan commented Aug 14, 2023

Description

Update the otel submodule. The diff is DCGM: Enable the receiver to retry dcgm initialization at each collection time.

Related issue

b/292514145

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@LujieDuan LujieDuan added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 14, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 14, 2023
@LujieDuan LujieDuan added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 14, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 14, 2023
@LujieDuan
Copy link
Contributor Author

LujieDuan commented Aug 14, 2023

Windows third party tests failed multiple times for mssql - b/295867239. Should not related to the otel upgrade. Will merge this just before #1330.

@LujieDuan LujieDuan requested review from a team, hsmatulisgoogle and franciscovalentecastro and removed request for a team and hsmatulisgoogle August 14, 2023 17:59
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Modulo all tests pass or are flakes.

@LujieDuan LujieDuan force-pushed the lujieduan-update-otelopscol-dcgm-retry branch from 72271ba to bef3223 Compare August 14, 2023 18:51
@LujieDuan LujieDuan added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 14, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 14, 2023
@LujieDuan LujieDuan added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 14, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 14, 2023
@LujieDuan LujieDuan merged commit 3da5be0 into master Aug 15, 2023
@LujieDuan LujieDuan deleted the lujieduan-update-otelopscol-dcgm-retry branch August 15, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants