Revert "Stop ignoring errors in sub-agent startup (#59)" (#66)

GoogleCloudPlatform · Apr 22, 2021 · 387c129 · 387c129
1 parent 2c14157
commit 387c129
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/cmd/ops_agent_windows/run_windows.go b/cmd/ops_agent_windows/run_windows.go
@@ -45,8 +45,7 @@ func (s *service) Execute(args []string, r <-chan svc.ChangeRequest, changes cha
 	changes <- svc.Status{State: svc.Running, Accepts: cmdsAccepted}
 	if err := s.startSubagents(); err != nil {
 		s.log.Error(1, fmt.Sprintf("failed to start subagents: %v", err))
-		// ERROR_SERVICE_DEPENDENCY_FAIL
-		return false, 0x0000042C
+		// TODO: Ignore failures for partial startup?
 	}
 	s.log.Info(1, "started subagents")
 	defer func() {
@@ -150,7 +149,8 @@ func (s *service) startSubagents() error {
 		}
 		defer handle.Close()
 		if err := handle.Start(); err != nil {
-			return fmt.Errorf("failed to start %q: %v", svc.name, err)
+			// TODO: Should we be ignoring failures for partial startup?
+			s.log.Error(1, fmt.Sprintf("failed to start %q: %v", svc.name, err))
 		}
 	}
 	return nil