Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maxtext GPU test now point to image built using mode=stable #566

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

parambole
Copy link
Collaborator

Description

Since JStS image is not yet publicly released reverting changes so that maxtext gpu test now point to image which is built using mode=stable

ref: AI-Hypercomputer/maxtext#1173

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@yangyuwei yangyuwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Param for the quick fix!

I think it's better to hold on merging this PR until AI-Hypercomputer/maxtext#1173 is merged and executed, otherwise, there will be no stable docker images that can be used by XLML tests.

In addition, it'd be great if you could run the tests to verify after the new stable docker image gets uploaded.

Does it make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants