feat: strengthen the load generator with fuzz input #2389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NimJay
requested changes
Feb 26, 2024
src/loadgenerator/requirements.txt
Outdated
| @@ -70,6 +70,7 @@ zope-event==5.0 | |||
| # via gevent | |||
| zope-interface==6.1 | |||
| # via gevent | |||
|
|
|||
| faker==23.2.1 | |||
| # via faker | |||
There was a problem hiding this comment.
Issue: This faker import should be specified inside src/loadgenerator/requirements.in.
| 'quantity': random.choice([1,2,3,4,5,10])}) | ||
| 'quantity': random.randint(1,100)}) | ||
|
|
||
| def empty_cart(l): |
There was a problem hiding this comment.
Thought:
Other method names use camelCase, but empty_cart is good.
We should use snake_case for Python function names, based on this StackOverflow post.
No action needed (since this is out-of-scope for your change and you've gotten it right).
There was a problem hiding this comment.
I've opened #2397. No action needed from this pull-request.
Lincyaw
force-pushed
the
feat/addmockrequest
branch
from
2edbc92 to
7878b9f
Compare
|
Thanks for your review! I will open another pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The original load generator only sends the same request template, which lacks diversity.
Adding a fuzzy-style request generator will make the request more general.