feat: add Chronicle DashboardChart resources by divyamjain000 · Pull Request #16734 · GoogleCloudPlatform/magic-modules

divyamjain000 · 2026-03-17T05:40:03Z

This PR introduces Terraform support for the Chronicle Dashboard Chart resource by adding the google_chronicle_dashboard_chart resource.

This includes:

Schema definition for the resource.
Create and Update functionalities.
Acceptance tests to cover the resource lifecycle.
Adds tests for fields introduced in feat: add Chronicle NativeDashboard resource #16735

Related Issue
Fixes hashicorp/terraform-provider-google#26520

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_chronicle_dashboard_chart`

modular-magician · 2026-03-17T05:50:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 10374 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 10374 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 3346 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_dashboard_chart (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_dashboard_chart" "primary" {
  chart_id = # value needed
  dashboard_chart {
    chart_datasource {
      dashboard_query = # value needed
    }
    drill_down_config {
      left_drill_downs {
        custom_settings {
          external_link {
            description = # value needed
          }
          filter {
            dashboard_filters {
              dashboard_filter_id = # value needed
              filter_operator_and_values {
                field_values    = # value needed
                filter_operator = # value needed
              }
            }
          }
          left_click_column = # value needed
          query {
            query = # value needed
          }
        }
        default_settings {
          enabled = # value needed
        }
      }
      right_drill_downs {
        custom_settings {
          external_link {
            description = # value needed
            link        = # value needed
          }
          filter {
            dashboard_filters {
              dashboard_filter_id = # value needed
              filter_operator_and_values {
                field_values    = # value needed
                filter_operator = # value needed
              }
            }
          }
          left_click_column = # value needed
          new_tab           = # value needed
          query {
            query = # value needed
          }
        }
        default_settings {
          enabled = # value needed
        }
        display_name = # value needed
        id           = # value needed
      }
    }
    visualization {
      button {
        description = # value needed
        hyperlink   = # value needed
        label       = # value needed
        new_tab     = # value needed
        properties {
          button_style = # value needed
          color        = # value needed
        }
      }
      google_maps_config {
        data_settings {
          count_column     = # value needed
          latitude_column  = # value needed
          longitude_column = # value needed
        }
        map_position {
          fit_data         = # value needed
          latitude_value   = # value needed
          longitude_value  = # value needed
          zoom_scale_value = # value needed
        }
        plot_mode = # value needed
        point_settings {
          color           = # value needed
          point_size_type = # value needed
        }
      }
      legends {
        bottom       = # value needed
        id           = # value needed
        left         = # value needed
        legend_align = # value needed
        padding      = # value needed
        right        = # value needed
        show         = # value needed
        z            = # value needed
        z_level      = # value needed
      }
      markdown {
        content = # value needed
        properties {
          background_color = # value needed
        }
      }
      series {
        area_style {
          color           = # value needed
          opacity         = # value needed
          origin          = # value needed
          shadow_blur     = # value needed
          shadow_color    = # value needed
          shadow_offset_x = # value needed
          shadow_offset_y = # value needed
        }
        data_label {
          show = # value needed
        }
        encode {
          item_name = # value needed
          value     = # value needed
        }
        field = # value needed
        gauge_config {
          base_value {
            color = # value needed
            value = # value needed
          }
          limit_value {
            color = # value needed
            value = # value needed
          }
          threshold_values {
            color = # value needed
            value = # value needed
          }
        }
        item_colors {
          colors {
            key = # value needed
            value {
              color = # value needed
              label = # value needed
            }
          }
        }
        item_style {
          border_color = # value needed
          border_width = # value needed
          color        = # value needed
        }
        label = # value needed
        metric_trend_config {
          metric_display_trend = # value needed
          metric_format        = # value needed
          metric_trend_type    = # value needed
          show_metric_trend    = # value needed
        }
        radius                = # value needed
        series_name           = # value needed
        series_stack_strategy = # value needed
        series_unique_value   = # value needed
        show_background       = # value needed
        show_symbol           = # value needed
        stack                 = # value needed
      }
      table_config {
        column_render_type_settings {
          column_render_type = # value needed
          field              = # value needed
        }
        column_tooltip_settings {
          cell_tooltip_text   = # value needed
          field               = # value needed
          header_tooltip_text = # value needed
        }
      }
      tooltip {
        show            = # value needed
        tooltip_trigger = # value needed
      }
      visual_maps {
        pieces {
          color = # value needed
          label = # value needed
          max   = # value needed
          min   = # value needed
        }
        visual_map_type = # value needed
      }
      x_axes {
        max = # value needed
        min = # value needed
      }
      y_axes {
        max = # value needed
        min = # value needed
      }
    }
  }
  dashboard_query {
    input {
      time_window {
        end_time   = # value needed
        start_time = # value needed
      }
    }
  }
}

Resource: google_chronicle_native_dashboard (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_native_dashboard" "primary" {
  dashboard_id = # value needed
  filters {
    chart_ids    = # value needed
    is_mandatory = # value needed
  }
}

Multiple resources added

This PR adds multiple new resources: google_chronicle_dashboard_chart, google_chronicle_native_dashboard. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2026-03-17T05:53:47Z

Tests analytics

Total tests: 30
Passed tests: 24
Skipped tests: 1
Affected tests: 5

Click here to see the affected service packages

chronicle

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccChronicleDashboardChart_chronicleDashboardchartBasicExample

TestAccChronicleDashboardChart_chronicleDashboardchartFullExample

TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update

TestAccChronicleNativeDashboard_chronicleNativedashboardBasicExample

TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample

Get to know how VCR tests work

modular-magician · 2026-03-17T05:54:42Z

🟢 Tests passed during RECORDING mode:
TestAccChronicleDashboardChart_chronicleDashboardchartBasicExample [Debug log]
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample [Debug log]
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update [Debug log]
TestAccChronicleNativeDashboard_chronicleNativedashboardBasicExample [Debug log]
TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-03-17T11:15:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 10693 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 10693 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 3346 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_dashboard_chart (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_dashboard_chart" "primary" {
  chart_id = # value needed
  dashboard_chart {
    chart_datasource {
      dashboard_query = # value needed
    }
    drill_down_config {
      left_drill_downs {
        custom_settings {
          external_link {
            description = # value needed
          }
          filter {
            dashboard_filters {
              dashboard_filter_id = # value needed
              filter_operator_and_values {
                field_values    = # value needed
                filter_operator = # value needed
              }
            }
          }
          left_click_column = # value needed
          query {
            query = # value needed
          }
        }
        default_settings {
          enabled = # value needed
        }
      }
      right_drill_downs {
        custom_settings {
          external_link {
            description = # value needed
            link        = # value needed
          }
          filter {
            dashboard_filters {
              dashboard_filter_id = # value needed
              filter_operator_and_values {
                field_values    = # value needed
                filter_operator = # value needed
              }
            }
          }
          left_click_column = # value needed
          new_tab           = # value needed
          query {
            query = # value needed
          }
        }
        default_settings {
          enabled = # value needed
        }
        display_name = # value needed
        id           = # value needed
      }
    }
    visualization {
      button {
        description = # value needed
      }
      google_maps_config {
        map_position {
          latitude_value   = # value needed
          longitude_value  = # value needed
          zoom_scale_value = # value needed
        }
        point_settings {
          color           = # value needed
          point_size_type = # value needed
        }
      }
      legends {
        bottom       = # value needed
        id           = # value needed
        left         = # value needed
        legend_align = # value needed
        padding      = # value needed
        right        = # value needed
        show         = # value needed
        z            = # value needed
        z_level      = # value needed
      }
      series {
        area_style {
          color           = # value needed
          opacity         = # value needed
          origin          = # value needed
          shadow_blur     = # value needed
          shadow_color    = # value needed
          shadow_offset_x = # value needed
          shadow_offset_y = # value needed
        }
        data_label {
          show = # value needed
        }
        encode {
          item_name = # value needed
          value     = # value needed
        }
        field = # value needed
        gauge_config {
          base_value {
            color = # value needed
            value = # value needed
          }
          limit_value {
            color = # value needed
            value = # value needed
          }
          threshold_values {
            color = # value needed
            value = # value needed
          }
        }
        item_colors {
          colors {
            key = # value needed
            value {
              color = # value needed
              label = # value needed
            }
          }
        }
        item_style {
          border_color = # value needed
          border_width = # value needed
        }
        label = # value needed
        metric_trend_config {
          metric_display_trend = # value needed
          metric_format        = # value needed
          metric_trend_type    = # value needed
          show_metric_trend    = # value needed
        }
        series_name           = # value needed
        series_stack_strategy = # value needed
        series_unique_value   = # value needed
        show_background       = # value needed
        show_symbol           = # value needed
        stack                 = # value needed
      }
      table_config {
        column_render_type_settings {
          column_render_type = # value needed
          field              = # value needed
        }
        column_tooltip_settings {
          cell_tooltip_text   = # value needed
          field               = # value needed
          header_tooltip_text = # value needed
        }
      }
      tooltip {
        show            = # value needed
        tooltip_trigger = # value needed
      }
      visual_maps {
        pieces {
          color = # value needed
          label = # value needed
          max   = # value needed
          min   = # value needed
        }
        visual_map_type = # value needed
      }
      x_axes {
        max = # value needed
        min = # value needed
      }
      y_axes {
        max = # value needed
        min = # value needed
      }
    }
  }
  dashboard_query {
    input {
      time_window {
        end_time   = # value needed
        start_time = # value needed
      }
    }
  }
}

Resource: google_chronicle_native_dashboard (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_native_dashboard" "primary" {
  dashboard_id = # value needed
  filters {
    chart_ids    = # value needed
    is_mandatory = # value needed
  }
}

Multiple resources added

This PR adds multiple new resources: google_chronicle_dashboard_chart, google_chronicle_native_dashboard. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2026-03-17T11:19:15Z

Tests analytics

Total tests: 30
Passed tests: 27
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages

chronicle

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccChronicleDashboardChart_chronicleDashboardchartFullExample

TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update

Get to know how VCR tests work

modular-magician · 2026-03-17T11:20:32Z

🟢 Tests passed during RECORDING mode:
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample [Debug log]
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-03-18T09:16:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 10770 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 10770 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 3346 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_dashboard_chart (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_dashboard_chart" "primary" {
  chart_id = # value needed
  dashboard_chart {
    chart_datasource {
      dashboard_query = # value needed
    }
    drill_down_config {
      left_drill_downs {
        custom_settings {
          filter {
            dashboard_filters {
              dashboard_filter_id = # value needed
              filter_operator_and_values {
                field_values    = # value needed
                filter_operator = # value needed
              }
            }
          }
          left_click_column = # value needed
          query {
            query = # value needed
          }
        }
        default_settings {
          enabled = # value needed
        }
      }
      right_drill_downs {
        custom_settings {
          external_link {
            description = # value needed
            link        = # value needed
          }
          filter {
            dashboard_filters {
              dashboard_filter_id = # value needed
              filter_operator_and_values {
                field_values    = # value needed
                filter_operator = # value needed
              }
            }
          }
          left_click_column = # value needed
          new_tab           = # value needed
          query {
            query = # value needed
          }
        }
        default_settings {
          enabled = # value needed
        }
        display_name = # value needed
        id           = # value needed
      }
    }
    visualization {
      google_maps_config {
        data_settings {
          count_column     = # value needed
          latitude_column  = # value needed
          longitude_column = # value needed
        }
        map_position {
          fit_data         = # value needed
          latitude_value   = # value needed
          longitude_value  = # value needed
          zoom_scale_value = # value needed
        }
        plot_mode = # value needed
        point_settings {
          color           = # value needed
          point_size_type = # value needed
        }
      }
      series {
        area_style {
          color           = # value needed
          opacity         = # value needed
          origin          = # value needed
          shadow_blur     = # value needed
          shadow_color    = # value needed
          shadow_offset_x = # value needed
          shadow_offset_y = # value needed
        }
        encode {
          item_name = # value needed
          value     = # value needed
        }
        field = # value needed
        gauge_config {
          base_value {
            color = # value needed
            value = # value needed
          }
          limit_value {
            color = # value needed
            value = # value needed
          }
          threshold_values {
            color = # value needed
            value = # value needed
          }
        }
        item_colors {
          colors {
            key = # value needed
            value {
              color = # value needed
              label = # value needed
            }
          }
        }
        item_style {
          border_color = # value needed
          border_width = # value needed
        }
        label = # value needed
        metric_trend_config {
          metric_display_trend = # value needed
          metric_format        = # value needed
          metric_trend_type    = # value needed
          show_metric_trend    = # value needed
        }
        series_name           = # value needed
        series_stack_strategy = # value needed
        series_unique_value   = # value needed
        show_background       = # value needed
        show_symbol           = # value needed
        stack                 = # value needed
      }
      table_config {
        column_render_type_settings {
          column_render_type = # value needed
          field              = # value needed
        }
        column_tooltip_settings {
          cell_tooltip_text   = # value needed
          field               = # value needed
          header_tooltip_text = # value needed
        }
      }
      tooltip {
        show            = # value needed
        tooltip_trigger = # value needed
      }
      visual_maps {
        pieces {
          color = # value needed
          label = # value needed
          max   = # value needed
          min   = # value needed
        }
        visual_map_type = # value needed
      }
      x_axes {
        max = # value needed
        min = # value needed
      }
      y_axes {
        max = # value needed
        min = # value needed
      }
    }
  }
}

Resource: google_chronicle_native_dashboard (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_native_dashboard" "primary" {
  dashboard_id = # value needed
  filters {
    chart_ids    = # value needed
    is_mandatory = # value needed
  }
}

Multiple resources added

This PR adds multiple new resources: google_chronicle_dashboard_chart, google_chronicle_native_dashboard. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2026-03-18T09:20:03Z

Tests analytics

Total tests: 30
Passed tests: 26
Skipped tests: 1
Affected tests: 3

Click here to see the affected service packages

chronicle

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccChronicleDashboardChart_chronicleDashboardchartFullExample

TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update

TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample

Get to know how VCR tests work

modular-magician · 2026-03-18T09:20:32Z

🔴 Tests failed during RECORDING mode:
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample [Error message] [Debug log]
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update [Error message] [Debug log]
TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-03-18T10:53:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 11063 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 11063 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 3341 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_dashboard_chart (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_dashboard_chart" "primary" {
  dashboard_chart {
    drill_down_config {
      left_drill_downs {
        custom_settings {
          left_click_column = # value needed
          query {
            query = # value needed
          }
        }
        default_settings {
          enabled = # value needed
        }
      }
      right_drill_downs {
        custom_settings {
          external_link {
            description = # value needed
          }
          left_click_column = # value needed
        }
        default_settings {
          enabled = # value needed
        }
      }
    }
    visualization {
      series {
        item_colors {
          colors {
            key = # value needed
            value {
              color = # value needed
              label = # value needed
            }
          }
        }
        series_name           = # value needed
        series_stack_strategy = # value needed
        show_background       = # value needed
        show_symbol           = # value needed
        stack                 = # value needed
      }
      table_config {
        column_render_type_settings {
          column_render_type = # value needed
          field              = # value needed
        }
        column_tooltip_settings {
          cell_tooltip_text   = # value needed
          field               = # value needed
          header_tooltip_text = # value needed
        }
      }
      tooltip {
        show            = # value needed
        tooltip_trigger = # value needed
      }
      visual_maps {
        pieces {
          label = # value needed
        }
      }
      x_axes {
        max = # value needed
        min = # value needed
      }
      y_axes {
        max = # value needed
        min = # value needed
      }
    }
  }
}

Resource: google_chronicle_native_dashboard (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_native_dashboard" "primary" {
  charts {
    dashboard_chart = # value needed
  }
  filters {
    chart_ids    = # value needed
    is_mandatory = # value needed
  }
}

Multiple resources added

This PR adds multiple new resources: google_chronicle_dashboard_chart, google_chronicle_native_dashboard. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2026-03-18T10:56:43Z

Tests analytics

Total tests: 30
Passed tests: 25
Skipped tests: 1
Affected tests: 4

Click here to see the affected service packages

chronicle

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccChronicleDashboardChart_chronicleDashboardchartFullExample

TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update

TestAccChronicleNativeDashboard_chronicleNativedashboardBasicExample

TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample

Get to know how VCR tests work

modular-magician · 2026-03-18T10:58:14Z

🟢 Tests passed during RECORDING mode:
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample [Debug log]
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update [Debug log]
TestAccChronicleNativeDashboard_chronicleNativedashboardBasicExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-03-18T11:31:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 11065 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 11065 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 3341 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_dashboard_chart (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_dashboard_chart" "primary" {
  dashboard_chart {
    drill_down_config {
      left_drill_downs {
        custom_settings {
          left_click_column = # value needed
          query {
            query = # value needed
          }
        }
        default_settings {
          enabled = # value needed
        }
      }
      right_drill_downs {
        custom_settings {
          external_link {
            description = # value needed
          }
          left_click_column = # value needed
        }
        default_settings {
          enabled = # value needed
        }
      }
    }
    visualization {
      series {
        item_colors {
          colors {
            key = # value needed
            value {
              color = # value needed
              label = # value needed
            }
          }
        }
        series_name           = # value needed
        series_stack_strategy = # value needed
        show_background       = # value needed
        show_symbol           = # value needed
        stack                 = # value needed
      }
      table_config {
        column_render_type_settings {
          column_render_type = # value needed
          field              = # value needed
        }
        column_tooltip_settings {
          cell_tooltip_text   = # value needed
          field               = # value needed
          header_tooltip_text = # value needed
        }
      }
      tooltip {
        show            = # value needed
        tooltip_trigger = # value needed
      }
      visual_maps {
        pieces {
          label = # value needed
        }
      }
      x_axes {
        max = # value needed
        min = # value needed
      }
      y_axes {
        max = # value needed
        min = # value needed
      }
    }
  }
}

Resource: google_chronicle_native_dashboard (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_native_dashboard" "primary" {
  charts {
    dashboard_chart = # value needed
  }
  filters {
    chart_ids    = # value needed
    is_mandatory = # value needed
  }
}

Multiple resources added

This PR adds multiple new resources: google_chronicle_dashboard_chart, google_chronicle_native_dashboard. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2026-03-18T11:35:55Z

Tests analytics

Total tests: 30
Passed tests: 24
Skipped tests: 1
Affected tests: 5

Click here to see the affected service packages

chronicle

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccChronicleDashboardChart_chronicleDashboardchartBasicExample

TestAccChronicleDashboardChart_chronicleDashboardchartFullExample

TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update

TestAccChronicleNativeDashboard_chronicleNativedashboardBasicExample

TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample

Get to know how VCR tests work

modular-magician · 2026-03-18T11:37:53Z

🟢 Tests passed during RECORDING mode:
TestAccChronicleDashboardChart_chronicleDashboardchartBasicExample [Debug log]
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample [Debug log]
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update [Debug log]
TestAccChronicleNativeDashboard_chronicleNativedashboardBasicExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-03-20T04:34:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 11065 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 11065 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 3341 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_dashboard_chart (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_dashboard_chart" "primary" {
  dashboard_chart {
    drill_down_config {
      left_drill_downs {
        custom_settings {
          left_click_column = # value needed
          query {
            query = # value needed
          }
        }
        default_settings {
          enabled = # value needed
        }
      }
      right_drill_downs {
        custom_settings {
          external_link {
            description = # value needed
          }
          left_click_column = # value needed
        }
        default_settings {
          enabled = # value needed
        }
      }
    }
    visualization {
      series {
        item_colors {
          colors {
            key = # value needed
            value {
              color = # value needed
              label = # value needed
            }
          }
        }
        series_name           = # value needed
        series_stack_strategy = # value needed
        show_background       = # value needed
        show_symbol           = # value needed
        stack                 = # value needed
      }
      table_config {
        column_render_type_settings {
          column_render_type = # value needed
          field              = # value needed
        }
        column_tooltip_settings {
          cell_tooltip_text   = # value needed
          field               = # value needed
          header_tooltip_text = # value needed
        }
      }
      tooltip {
        show            = # value needed
        tooltip_trigger = # value needed
      }
      visual_maps {
        pieces {
          label = # value needed
        }
      }
      x_axes {
        max = # value needed
        min = # value needed
      }
      y_axes {
        max = # value needed
        min = # value needed
      }
    }
  }
}

Resource: google_chronicle_native_dashboard (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_native_dashboard" "primary" {
  charts {
    dashboard_chart = # value needed
  }
  filters {
    is_mandatory = # value needed
  }
}

Multiple resources added

This PR adds multiple new resources: google_chronicle_dashboard_chart, google_chronicle_native_dashboard. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2026-03-20T04:37:33Z

Tests analytics

Total tests: 30
Passed tests: 27
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages

chronicle

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update

TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample

Get to know how VCR tests work

modular-magician · 2026-03-20T04:39:07Z

🟢 Tests passed during RECORDING mode:
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician added the service/chronicle label Mar 17, 2026

modular-magician requested a review from ankitgoyal0301 March 17, 2026 05:50

divyamjain000 mentioned this pull request Mar 17, 2026

feat: add Chronicle NativeDashboard resource #16735

Open

divyamjain000 force-pushed the chronicle-dashboardchart-divyamjain branch from e1835b7 to 42d188f Compare March 17, 2026 11:04

divyamjain000 force-pushed the chronicle-dashboardchart-divyamjain branch from 42d188f to 85f9362 Compare March 18, 2026 09:03

divyamjain000 force-pushed the chronicle-dashboardchart-divyamjain branch from 85f9362 to b58bc51 Compare March 18, 2026 10:41

divyamjain000 force-pushed the chronicle-dashboardchart-divyamjain branch from b58bc51 to 14a70b8 Compare March 18, 2026 11:18

feat: add Chronicle NativeDashboard and DashboardChart resources

6040891

divyamjain000 force-pushed the chronicle-dashboardchart-divyamjain branch from 14a70b8 to 6040891 Compare March 20, 2026 04:22

Conversation

divyamjain000 commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Mar 17, 2026

Diff report

Missing test report

Multiple resources added

Uh oh!

modular-magician commented Mar 17, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 17, 2026

Uh oh!

modular-magician commented Mar 17, 2026

Diff report

Missing test report

Multiple resources added

Uh oh!

modular-magician commented Mar 17, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 17, 2026

Uh oh!

modular-magician commented Mar 18, 2026

Diff report

Missing test report

Multiple resources added

Uh oh!

modular-magician commented Mar 18, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 18, 2026

Uh oh!

modular-magician commented Mar 18, 2026

Diff report

Missing test report

Multiple resources added

Uh oh!

modular-magician commented Mar 18, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 18, 2026

Uh oh!

modular-magician commented Mar 18, 2026

Diff report

Missing test report

Multiple resources added

Uh oh!

modular-magician commented Mar 18, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 18, 2026

Uh oh!

modular-magician commented Mar 20, 2026

Diff report

Missing test report

Multiple resources added

Uh oh!

modular-magician commented Mar 20, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

divyamjain000 commented Mar 17, 2026 •

edited

Loading