Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Update node-termination-handler image version #14

Merged
merged 1 commit into from
May 7, 2019
Merged

Update node-termination-handler image version #14

merged 1 commit into from
May 7, 2019

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented May 1, 2019

Related issue #13

@yuwenma
Copy link
Contributor Author

yuwenma commented May 1, 2019

/assign @vishh @mindprince

deploy/k8s.yaml Outdated Show resolved Hide resolved
@vishh
Copy link
Contributor

vishh commented May 2, 2019

Can you also update the Dockerfiles to build off of the new distroless base image? Otherwise a future image push might break your change.

Copy link
Contributor Author

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for another look :)

Copy link
Contributor

@vishh vishh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dockerfile.build Outdated Show resolved Hide resolved
@yuwenma
Copy link
Contributor Author

yuwenma commented May 7, 2019

Gentle ping.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants