-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout values added #16
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
Test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question
@@ -149,16 +149,16 @@ install_app() { | |||
kubectl -n default create -f "${REPO_HOME}/manifests/es-svc.yaml" | |||
kubectl -n default create -f "${REPO_HOME}/manifests/es-master-pdb.yaml" | |||
kubectl -n default create -f "${REPO_HOME}/manifests/es-master.yaml" | |||
kubectl -n default rollout status -f "${REPO_HOME}/manifests/es-master.yaml" | |||
kubectl -n default rollout status --timeout=2m -f "${REPO_HOME}/manifests/es-master.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should eventually loop here if this fails. But this work for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it works for now. I added a buffer of extra '1m' as you said sometimes cloud can act crazy.
Test this please |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign |
Test this please |
Added Timeout values for both blue-green-upgrade and expand-contract-upgrade in Gke-rolling-updates-demo repo. I verified the timeout values and added a buffer '1m' more..the way you asked me to.