Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gcpAuthzPolicy CRD #199

Merged
merged 1 commit into from
Aug 22, 2024
Merged

add gcpAuthzPolicy CRD #199

merged 1 commit into from
Aug 22, 2024

Conversation

aryan16
Copy link
Contributor

@aryan16 aryan16 commented Aug 15, 2024

Added GCPAuthzPolicy CRD with testing around CEL validations.

@aryan16 aryan16 changed the title add gcpAuthzPoicy CRD add gcpAuthzPolicy CRD Aug 15, 2024
robscott
robscott reviewed Aug 21, 2024
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aryan16!

authz/invalid_http_rules.yaml Outdated Show resolved Hide resolved
authz/setup.sh Outdated Show resolved Hide resolved
authz/setup.sh Outdated Show resolved Hide resolved
@robscott
Copy link
Member

Actually - one last comment that I can't actually leave on a line of code. The cleanup.sh file is empty, were you planning to add code to that or delete it?

@aryan16
Copy link
Contributor Author

aryan16 commented Aug 21, 2024

Actually - one last comment that I can't actually leave on a line of code. The cleanup.sh file is empty, were you planning to Added cleanup code to delete the cluster?

@aryan16 aryan16 force-pushed the authz-crd branch 2 times, most recently from 10cbd85 to e3b3448 Compare August 21, 2024 20:32
@aryan16
Copy link
Contributor Author

aryan16 commented Aug 21, 2024

Actually - one last comment that I can't actually leave on a line of code. The cleanup.sh file is empty, were you planning to add code to that or delete it?

Done.

@aryan16 aryan16 requested a review from robscott August 21, 2024 20:33
robscott
robscott approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aryan16!

authz/authz-cr-validation/invalid_provider_custom.yaml Outdated Show resolved Hide resolved
authz/authz-cr-validation/run-test.sh Show resolved Hide resolved
@aryan16 aryan16 force-pushed the authz-crd branch 2 times, most recently from fad8225 to 300fb86 Compare August 21, 2024 22:30
@aryan16
Copy link
Contributor Author

aryan16 commented Aug 21, 2024

@boredabdel could you please review this one.

robscott
robscott approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aryan16!

/lgtm
/assign @bowei

@bowei
Copy link
Member

bowei commented Aug 22, 2024

/lgtm
/approve

@bowei bowei merged commit 1e93516 into GoogleCloudPlatform:main Aug 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei approved these changes

@robscott robscott robscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aryan16 @robscott @bowei