Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Fixed ZONE as primary_location #36

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

falico
Copy link
Contributor

@falico falico commented Nov 23, 2019

The current fix for #35 forgot to also change the ZONE variable in scripts/validate.sh

The current fix for GoogleCloudPlatform#35 forgot to also change the ZONE variable in scripts/validate.sh
@helmsman-bot
Copy link

Can one of the admins verify this patch?

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: falico
To complete the pull request process, please assign robinpercy
You can assign the PR to them by writing /assign @robinpercy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot added the gke-helmsman PSO helmsman project label Nov 23, 2019
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no No CLA signed label Nov 23, 2019
@falico
Copy link
Contributor Author

falico commented Nov 23, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA verified and removed cla: no No CLA signed labels Nov 23, 2019
@falico
Copy link
Contributor Author

falico commented Jan 2, 2020

/assign @robinpercy

Copy link
Contributor

@geojaz geojaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks!

@kaariger kaariger merged commit ad62acb into GoogleCloudPlatform:master Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes CLA verified gke-helmsman PSO helmsman project size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants