Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: autosxs evaluation for custom tasks (translation in a media news scenario). #863

Merged

Conversation

inardini
Copy link
Contributor

@inardini inardini commented Jul 11, 2024

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • You are listed as the author in your notebook or README file.
    • Your account is listed in CODEOWNERS for the file(s).
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format).
  • Appropriate docs were updated (if necessary)

@inardini inardini requested a review from a team as a code owner July 11, 2024 14:53
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2024

This comment has been minimized.

@holtskinner
Copy link
Collaborator

@inardini For the spell-check I'm going to try and add an Italian dictionary so we don't have to allowlist all of these separately

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2024

This comment has been minimized.

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2024

This comment has been minimized.

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2024

This comment has been minimized.

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2024

This comment has been minimized.

@gericdong
Copy link
Contributor

The spelling check can't handle a different language at the moment.

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2024

This comment has been minimized.

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2024

This comment has been minimized.

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2024

This comment has been minimized.

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2024

This comment has been minimized.

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2024
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (103)
abbonati
accedere
agli
alla
alle
analisi
argomento
avuto
azioni
buona
calo
clienti
coloro
colpiti
completi
contenuti
correlato
dati
degli
delle
dello
Digitale
diretta
diretto
discutere
Dobbiamo
domani
Dovremmo
durata
entrate
entro
esatta
esistenti
Esperto
eventi
fornire
fsspec
futuri
garantire
gcsfs
gestire
gesto
gli
grado
hanno
impatto
kfp
mesi
mostrano
negli
nell'ultimo
nelle
nostre
nostri
nostro
notte
nuove
odierna
offrire
Oggetto
oggi
perdita
periodo
picchi
picco
possiamo
potuto
prego
prendere
prevenire
problema
puntano
queste
questo
rapporto
ricavi
richieste
riunione
sapete
sconto
scorsa
sia
simili
sito
soluzioni
specifed
stati
stato
stesso
Stiamo
stimata
sugli
sull'impatto
sulle
sullo
traffico
ultimi
un'impennata
uno
Urgente
utenti
Valutare
vicino
Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

Should be Vertex AI

\b(?!Vertex AI\b)(?!.*[\(\)\{\},])(?<!import\s)(?<!\.)(?<!,\s)Vertex\s?[Aa]?[Ii]?\b
Errors (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ forbidden-pattern 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

🚂 If you're seeing this message and your PR is from a branch that doesn't have check-spelling,
please merge to your PR's base branch to get the version configured for your repository.

@gericdong gericdong merged commit 193b1c3 into GoogleCloudPlatform:main Jul 15, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants