Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Added encoding = 'utf-8' while opening the Readme file #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anugrah86
Copy link

On Windows platform, it gives UnicodeDecodeError (as below) if we do not specify the encoding in Setup.py

UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 472: character maps to

So, I added the encoding to make it work.

On Windows platform, it gives UnicodeDecodeError (as below) if we do not specify the encoding. 

UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 472: character maps to <undefined>
@ricardolsmendes
Copy link
Contributor

Thanks for submitting such a fix @anugrah86.
Could you please sign the Contributor License Agreement (CLA) to have the present PR approved and merged? You'll find the instructions here.

@anugrah86
Copy link
Author

Hi Richard,

I have signed the Contributor License Agreement

Thanks,
Anugrah

@ricardolsmendes ricardolsmendes added bug Something isn't working qlik2datacatalog labels Jan 17, 2022
@ricardolsmendes
Copy link
Contributor

Hi @anugrah86, I've disabled the Greetings workflow that was causing CI to fail (#110, FYI). Could you please rebase your changes on top of master and force push them? Thanks!

@github-actions
Copy link

This PR has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 7 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this PR and helping to make Google Data Catalog Connectors better!

@ricardolsmendes
Copy link
Contributor

Hi @anugrah86, I've disabled the Greetings workflow that was causing CI to fail (#110, FYI). Could you please rebase your changes on top of master and force push them? Thanks!

Hi @anugrah86, may I assist you with the above rebase operation?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working qlik2datacatalog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants