Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub-open-telemetry): add quickstart example #265

Merged
merged 10 commits into from
Nov 28, 2023

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Nov 22, 2023

@alevenberg alevenberg requested a review from a team as a code owner November 22, 2023 19:58
Copy link

snippet-bot bot commented Nov 22, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

pubsub-open-telemetry/.bazelrc Outdated Show resolved Hide resolved
pubsub-open-telemetry/WORKSPACE.bazel Outdated Show resolved Hide resolved
pubsub-open-telemetry/quickstart.cc Outdated Show resolved Hide resolved
@alevenberg
Copy link
Member Author

Addressed comments

pubsub-open-telemetry/quickstart.cc Outdated Show resolved Hide resolved
pubsub-open-telemetry/quickstart.cc Show resolved Hide resolved
pubsub-open-telemetry/quickstart.cc Show resolved Hide resolved
pubsub-open-telemetry/CMakeLists.txt Outdated Show resolved Hide resolved
pubsub-open-telemetry/CMakeLists.txt Outdated Show resolved Hide resolved
pubsub-open-telemetry/README.md Outdated Show resolved Hide resolved
pubsub-open-telemetry/.bazelrc Outdated Show resolved Hide resolved
pubsub-open-telemetry/quickstart.cc Show resolved Hide resolved
pubsub-open-telemetry/quickstart.cc Show resolved Hide resolved
pubsub-open-telemetry/quickstart.cc Show resolved Hide resolved
pubsub-open-telemetry/CMakeLists.txt Outdated Show resolved Hide resolved
pubsub-open-telemetry/CMakeLists.txt Outdated Show resolved Hide resolved
pubsub-open-telemetry/vcpkg.json Outdated Show resolved Hide resolved
pubsub-open-telemetry/README.md Outdated Show resolved Hide resolved
pubsub-open-telemetry/README.md Outdated Show resolved Hide resolved
pubsub-open-telemetry/README.md Show resolved Hide resolved
pubsub-open-telemetry/README.md Outdated Show resolved Hide resolved
pubsub-open-telemetry/README.md Show resolved Hide resolved
pubsub-open-telemetry/quickstart.cc Show resolved Hide resolved
pubsub-open-telemetry/quickstart.cc Outdated Show resolved Hide resolved
@alevenberg
Copy link
Member Author

Installed cmake format in a venv locally and ran using cmake-format pubsub-open-telemetry/CMakeLists.txt -o pubsub-open-telemetry/CMakeLists.txt

@alevenberg alevenberg enabled auto-merge (squash) November 28, 2023 14:37
@alevenberg alevenberg merged commit 3bb52b8 into GoogleCloudPlatform:main Nov 28, 2023
6 checks passed
@alevenberg alevenberg deleted the samples branch November 28, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants