-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace TAS plugin with Kueue #3534
base: develop
Are you sure you want to change the base?
Replace TAS plugin with Kueue #3534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to delete the 2 node nccl test ?
- id: workload-manager-install | ||
source: modules/management/kubectl-apply | ||
use: [a3-ultragpu-cluster] | ||
settings: | ||
kueue: | ||
install: true | ||
version: v0.10.0 | ||
config_path: $(vars.kueue_configuration_path) | ||
config_template_vars: | ||
num_gpus: $(a3-ultragpu-pool.total_gpu_count) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super, so just to confirm if the nodepool size is changed via the toolkit, this config will be updated ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes- this number is fetched as an output of the node pool module. Calculated as allocatable_gpu_per_node * static_node_count. This is done so that user doesn't have to pass a redundant input (num_gpus)
Deleting this as well, since we have an n-node test now |
Deleted |
@@ -50,6 +50,11 @@ output "allocatable_gpu_per_node" { | |||
value = local.allocatable_gpu_per_node | |||
} | |||
|
|||
output "total_gpu_count" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if this should be static_gpu_count. Might have implications down the road for configuring Kueue with DWS Flex, since DWS Flex + Kueue could be configured with the total maximum scale.
What?
Why?
Kueue is the officially supported job scheduling utility for A3 Ultra
Testing
Ran Jobset based NCCL test, verified bandwidth figures
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.