Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Kubernetes 0.30.1 and associated controller-runtime. #593

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hessjcg
Copy link
Collaborator

@hessjcg hessjcg commented May 20, 2024

This upgrades the Kuberentes and Controller Runtime libraries to the latest available. It includes fixes for
superficial breaking changes in the Controller Runtime API.

@hessjcg hessjcg requested a review from a team as a code owner May 20, 2024 19:15
go 1.22
go 1.22.0

toolchain go1.22.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this was added automatically by go mod tidy. I'll revert it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, go mod tidy automatically updates:

go 1.22

to

go 1.22.0
toolchain go1.22.3

Apparently, this is the Go official way now. I think this change is necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a problem with a dependency we're pulling in. See golang/go#62409 as one example. I think we don't want to add the toolchain or the patch version here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hessjcg would you mind taking a closer look at this? This is surprising and unwanted behavior which I think is coming from one of the dependencies here (and might have a tracking bug for it already).

@@ -1,14 +1,16 @@
module github.com/GoogleCloudPlatform/cloud-sql-proxy-operator

go 1.22
go 1.22.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just go 1.22?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

infra/resources/database.tf Outdated Show resolved Hide resolved
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern here is the unwanted changes to go.mod. That looks like a bad dependency doing this.

go 1.22
go 1.22.0

toolchain go1.22.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hessjcg would you mind taking a closer look at this? This is surprising and unwanted behavior which I think is coming from one of the dependencies here (and might have a tracking bug for it already).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants