Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: asset path #100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Deleplace
Copy link

Fixes #98

I could confirm this code (after revert) works correctly:

  • locally
% go run . 
  • in Docker:
docker build -t cloud-run-hello-fix98 .
docker run -ePORT=8080 -p8080:8080 cloud-run-hello-fix98

@Deleplace
Copy link
Author

See also #99, which would avoid this ambiguity altogether

@Deleplace Deleplace requested a review from jihuin July 26, 2024 14:14
@jihuin
Copy link
Contributor

jihuin commented Jul 26, 2024

Hi Valentin, thanks for catching this. The purpose of PR #96 and #97 was to fix the broken deployment of the placeholder image to Cloud Run with automatic base image update (private preview feature).

Created PR #102 to cover all use cases.

@grayside
Copy link
Contributor

It looks like this PR's change was reimplemented and merged in #102. Are we good to close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken on local dev env
3 participants