Merge pull request #213 from GoogleCloudPlatform/issue212

bug: fixes checks for optional params
GoogleCloudPlatform · Mar 11, 2024 · d374791 · d374791
2 parents 207bfac + f9a54ca
commit d374791
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/internal/client/integrations/integrations.go b/internal/client/integrations/integrations.go
@@ -814,7 +814,7 @@ func GetAuthConfigs(integration []byte) (authcfgs []string, err error) {
 				}
 			}
 			authConfigNameParams := taskConfig.Parameters["authConfigName"]
-			if authConfigNameParams.Key == "authConfigName" {
+			if authConfigNameParams.Key == "authConfigName" && *authConfigNameParams.Value.StringValue != "" {
 				authConfigUuid, err := authconfigs.Find(*authConfigNameParams.Value.StringValue, "")
 				if err != nil {
 					return nil, fmt.Errorf("unable to find authconfig with name %s", *authConfigNameParams.Value.StringValue)
@@ -894,9 +894,11 @@ func GetConnectionsWithRegion(integration []byte) (connections []integrationConn
 				newConnection.CustomConnection = false
 				connections = append(connections, newConnection)
 			}
-			newConnection := getIntegrationConnection(taskConfig.Parameters["connectionName"],
-				taskConfig.Parameters["connectionVersion"], iversion.IntegrationConfigParameters)
-			connections = append(connections, newConnection)
+			if _, ok := taskConfig.Parameters["connectionName"]; ok {
+				newConnection := getIntegrationConnection(taskConfig.Parameters["connectionName"],
+					taskConfig.Parameters["connectionVersion"], iversion.IntegrationConfigParameters)
+				connections = append(connections, newConnection)
+			}
 		}
 	}
 	for _, triggerConfig := range iversion.TriggerConfigs {