Skip to content

Conversation

@derrickaw
Copy link
Contributor

@derrickaw derrickaw commented Dec 23, 2025

  1. Adds a new PubSubToBigTable blueprint and template
  2. Adds a helper support in pubsub
  3. Needs a windowing improvement before merging - pending PR - [yaml] - add multi-line windowing json support apache/beam#37174
  4. We previously expected the pending PR above to be needed for this PR, but the PR is only for multi-line support as single line string json is already supported. Hence why the tests passed on the PR.

@gemini-code-assist
Copy link

Summary of Changes

Hello @derrickaw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a new streaming Dataflow template, PubSub_To_BigTable_Yaml, designed to process messages from a Pub/Sub topic, apply custom field mappings, and write the transformed data to a BigTable instance. It also includes robust error handling, directing any failed transformations to a designated dead-letter Pub/Sub topic. The changes encompass the template's definition, associated documentation, and an integration test to validate its functionality.

Highlights

  • New Dataflow Template: Introduces a new PubSubToBigTable blueprint and template, enabling streaming data ingestion from Pub/Sub to BigTable with user-defined mappings.
  • Pub/Sub Helper Support: Adds a new builder method to PubsubMessagesCheck in the Pub/Sub resource manager, simplifying the creation of subscriptions for testing purposes.
  • Pending Windowing Improvement: Notes that a windowing improvement is needed for the template before merging, indicating a dependency on another pull request.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@derrickaw derrickaw added addition New feature or request improvement labels Dec 23, 2025
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.77%. Comparing base (a16c225) to head (0c8c437).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
.../it/gcp/pubsub/conditions/PubsubMessagesCheck.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               main    #3150    +/-   ##
==========================================
  Coverage     50.76%   50.77%            
- Complexity     5101     5484   +383     
==========================================
  Files           974      975     +1     
  Lines         59967    59986    +19     
  Branches       6551     6552     +1     
==========================================
+ Hits          30445    30458    +13     
- Misses        27378    27387     +9     
+ Partials       2144     2141     -3     
Components Coverage Δ
spanner-templates 70.93% <63.15%> (-0.01%) ⬇️
spanner-import-export 68.86% <ø> (+0.03%) ⬆️
spanner-live-forward-migration 80.03% <100.00%> (-0.03%) ⬇️
spanner-live-reverse-replication 77.64% <41.66%> (-0.10%) ⬇️
spanner-bulk-migration 88.48% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
.../it/gcp/pubsub/conditions/PubsubMessagesCheck.java 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw derrickaw marked this pull request as ready for review December 23, 2025 20:29
@tarun-google tarun-google self-requested a review December 29, 2025 15:39
@derrickaw derrickaw merged commit 9ed550a into GoogleCloudPlatform:main Dec 29, 2025
45 of 46 checks passed
@derrickaw derrickaw deleted the addPubSubToBT branch December 29, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants