-
Notifications
You must be signed in to change notification settings - Fork 519
Remove the unsupported 2.2-ubuntu22 from the table #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dialogbox, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the gpu/README.md documentation to ensure accuracy regarding supported Dataproc image versions for specific CUDA configurations. The change prevents users from attempting to utilize an image version that is not compatible with CUDA 11.8, thereby improving clarity and preventing potential issues.
Highlights
- Documentation Update: Removed the unsupported "2.2-ubuntu22" Dataproc image version from the CUDA 11.8 entry in the
gpu/README.mdfile. This correction ensures the documentation accurately reflects supported configurations.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This change correctly removes the unsupported 2.2-ubuntu22 image version for CUDA 11.8, aligning the documentation with the installation script's logic. I've also suggested updating the other version numbers on the same line to ensure full consistency with the script's defaults.
|
You are correct. I am going to accept this change into this omnibus I'm shipping shortly. Thank you. |
|
oops, I missed including this. I'll rebase onto main and propose this change. |
05d06db to
85e1ee7
Compare
|
sorry for all the misfires there. That lack of a final newline just didn't want to stick. I'm willing to merge this change now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/gcbrun |
#1356 This image is not supported for CUDA 11.8.