-
Notifications
You must be signed in to change notification settings - Fork 11
Added partial integration tests for pre-submit #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @fangyh20, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the integration test suite by making it more robust and compatible with CI/CD environments. It introduces dynamic authentication based on the execution environment, refines test session management for better resource handling, and strategically skips tests that are not yet ready for automated execution, ensuring a smoother pre-submit validation process. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several improvements to the integration tests to make them compatible with a CI/CD environment. Key changes include adding pytest markers, auto-detecting the authentication type based on the environment, and ensuring Spark sessions are properly cleaned up after tests. Some tests are temporarily skipped, and one is improved to use a randomized session ID to prevent conflicts. The changes are well-structured and significantly enhance the robustness of the test suite. I have one suggestion to improve error visibility during test cleanup.
Added github action for pre-submit
Added Service account based auth for integration test
Made the existing integration tests compatible with CI/CD
Made tests compatible with Spark4/runtime3.0
Changed pyspark.sql.functions -> pyspark.sql.connect.functions
Marked some of the tests skipped for now, pending for validation