Wrap individual puppeteer navigations in try/catch block #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
benchmark-web-vitals
with high numbers (e.g. 250) I would eventually encounter errors like:or
or
When these occur, the entire process quit early without completing all of the expected iterations over the URLs. I found that this was because there was a missing
try
/catch
block around each individual iteration. This meant it would move on to process the next URL which is where the existing exception handling is located:wpp-research/cli/commands/benchmark-web-vitals.mjs
Lines 385 to 393 in dca5646
By adding this additional
try
/catch
block, if there is a Puppeteer error, it will be the same as if the HTTP response returned with a failure. Such errors will then be reflected in the overall success rate.Review this PR with whitespace changes ignored.