feat: webExtension module #3012
Draft
+122
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Jan 21, 2025
| return { | ||
| extension: response.id, | ||
| }; | ||
| } catch (err: any) { |
There was a problem hiding this comment.
Suggested change
| } catch (err: any) { | |
| } catch (err) { |
instead cast the (error as Error) for type-safety.
OrKoN
reviewed
Jan 21, 2025
| const response = await this.#browserCdpClient.sendCommand( | ||
| 'Extensions.loadUnpacked', | ||
| { | ||
| path: (params.extensionData as WebExtension.ExtensionArchivePath) |
There was a problem hiding this comment.
for other types, we should throw an Unsupported exception as per spec https://w3c.github.io/webdriver-bidi/#expand-a-web-extension-data-spec
you can use a switch statement to cover all possible types of extensionData.
OrKoN
reviewed
Jan 21, 2025
| } from '../../../protocol/protocol.js'; | ||
|
|
||
| /** | ||
| * Responsible for handling the `storage` module. |
There was a problem hiding this comment.
Suggested change
| * Responsible for handling the `storage` module. | |
| * Responsible for handling the `webExtension` module. |
or delete the comment
OrKoN
reviewed
Jan 21, 2025
| * limitations under the License. | ||
| */ | ||
|
|
||
| /* |
OrKoN
reviewed
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR implement webExtension module