Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glob to v9.3.5 #3395

Draft
wants to merge 2 commits into
base: v7
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
206 changes: 122 additions & 84 deletions packages/workbox-build/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/workbox-build/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"common-tags": "^1.8.0",
"fast-json-stable-stringify": "^2.1.0",
"fs-extra": "^9.0.1",
"glob": "^7.1.6",
"glob": "^9.0.0",
"lodash": "^4.17.20",
"pretty-bytes": "^5.3.0",
"rollup": "^2.79.2",
Expand Down
2 changes: 0 additions & 2 deletions packages/workbox-build/src/lib/get-file-details.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ export function getFileDetails({
globFollow,
globIgnores,
globPattern,
globStrict,
}: Omit<GlobPartial, 'globDirectory' | 'globPatterns' | 'templatedURLs'> & {
// This will only be called when globDirectory is not undefined.
globDirectory: string;
Expand All @@ -43,7 +42,6 @@ export function getFileDetails({
cwd: globDirectory,
follow: globFollow,
ignore: globIgnores,
strict: globStrict,
});
} catch (err) {
throw new Error(
Expand Down
3 changes: 0 additions & 3 deletions packages/workbox-build/src/lib/get-file-manifest-entries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export async function getFileManifestEntries({
globFollow,
globIgnores,
globPatterns = [],
globStrict,
manifestTransforms,
maximumFileSizeToCacheInBytes,
modifyURLPrefix,
Expand All @@ -38,7 +37,6 @@ export async function getFileManifestEntries({
globFollow,
globIgnores,
globPattern,
globStrict,
});

if (warning) {
Expand Down Expand Up @@ -73,7 +71,6 @@ export async function getFileManifestEntries({
globFollow,
globIgnores,
globPattern,
globStrict,
});

if (warning) {
Expand Down
5 changes: 0 additions & 5 deletions packages/workbox-build/src/schema/GenerateSWOptions.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,6 @@
"type": "string"
}
},
"globStrict": {
"description": "If true, an error reading a directory when generating a precache manifest\nwill cause the build to fail. If false, the problematic directory will be\nskipped. For more information, see the definition of `strict` in the `glob`\n[documentation](https://github.com/isaacs/node-glob#options).",
"default": true,
"type": "boolean"
},
"templatedURLs": {
"description": "If a URL is rendered based on some server-side logic, its contents may\ndepend on multiple files or on some other unique string value. The keys in\nthis object are server-rendered URLs. If the values are an array of\nstrings, they will be interpreted as `glob` patterns, and the contents of\nany files matching the patterns will be used to uniquely version the URL.\nIf used with a single string, it will be interpreted as unique versioning\ninformation that you've generated for a given URL.",
"type": "object",
Expand Down
5 changes: 0 additions & 5 deletions packages/workbox-build/src/schema/GetManifestOptions.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,6 @@
"type": "string"
}
},
"globStrict": {
"description": "If true, an error reading a directory when generating a precache manifest\nwill cause the build to fail. If false, the problematic directory will be\nskipped. For more information, see the definition of `strict` in the `glob`\n[documentation](https://github.com/isaacs/node-glob#options).",
"default": true,
"type": "boolean"
},
"templatedURLs": {
"description": "If a URL is rendered based on some server-side logic, its contents may\ndepend on multiple files or on some other unique string value. The keys in\nthis object are server-rendered URLs. If the values are an array of\nstrings, they will be interpreted as `glob` patterns, and the contents of\nany files matching the patterns will be used to uniquely version the URL.\nIf used with a single string, it will be interpreted as unique versioning\ninformation that you've generated for a given URL.",
"type": "object",
Expand Down
5 changes: 0 additions & 5 deletions packages/workbox-build/src/schema/InjectManifestOptions.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,6 @@
"type": "string"
}
},
"globStrict": {
"description": "If true, an error reading a directory when generating a precache manifest\nwill cause the build to fail. If false, the problematic directory will be\nskipped. For more information, see the definition of `strict` in the `glob`\n[documentation](https://github.com/isaacs/node-glob#options).",
"default": true,
"type": "boolean"
},
"templatedURLs": {
"description": "If a URL is rendered based on some server-side logic, its contents may\ndepend on multiple files or on some other unique string value. The keys in\nthis object are server-rendered URLs. If the values are an array of\nstrings, they will be interpreted as `glob` patterns, and the contents of\nany files matching the patterns will be used to uniquely version the URL.\nIf used with a single string, it will be interpreted as unique versioning\ninformation that you've generated for a given URL.",
"type": "object",
Expand Down
8 changes: 0 additions & 8 deletions packages/workbox-build/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -404,14 +404,6 @@ export interface GlobPartial {
* @default ["**\/*.{js,wasm,css,html}"]
*/
globPatterns?: Array<string>;
/**
* If true, an error reading a directory when generating a precache manifest
* will cause the build to fail. If false, the problematic directory will be
* skipped. For more information, see the definition of `strict` in the `glob`
* [documentation](https://github.com/isaacs/node-glob#options).
* @default true
*/
globStrict?: boolean;
/**
* If a URL is rendered based on some server-side logic, its contents may
* depend on multiple files or on some other unique string value. The keys in
Expand Down
Loading