feat(spanner): add SavedSearchState table and locking logic #2056
+699
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the schema and client logic for managing the state of Saved Search notifications, specifically focusing on the ingestion worker locking mechanism. Changes: - Infrastructure: Added migration 000026.sql to create the `SavedSearchState` table with `SavedSearchId` and `SnapshotType` composite PK. - Client: Added `entityMutator` generic helper to `client.go` to support transactional "Read-Inspect-Write" patterns required for conditional locking. - Client: Added `SetTimeNowForTesting` to allow deterministic TTL expiration testing. - Feature: Implemented `saved_search_state.go` containing: - `TryAcquireSavedSearchStateWorkerLock` - `ReleaseSavedSearchStateWorkerLock` - `GetSavedSearchState` - `UpdateSavedSearchStateLastKnownStateBlobPath` - Tests: Added `saved_search_state_test.go` covering lock acquisition, expiration, re-acquisition, and release scenarios.
Collaborator
Author
|
This is not for this week's release. So feel free to deploy. @DanielRyanSmith |
jrobbins
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the schema and client logic for managing the state of Saved Search notifications, specifically focusing on the ingestion worker locking mechanism.
Changes:
SavedSearchStatetable withSavedSearchIdandSnapshotTypecomposite PK.entityMutatorgeneric helper toclient.goto support transactional "Read-Inspect-Write" patterns required for conditional locking.SetTimeNowForTestingto allow deterministic TTL expiration testing.saved_search_state.gocontaining:TryAcquireSavedSearchStateWorkerLockReleaseSavedSearchStateWorkerLockGetSavedSearchStateUpdateSavedSearchStateLastKnownStateBlobPathsaved_search_state_test.gocovering lock acquisition, expiration, re-acquisition, and release scenarios.