Add point selection handling to WebstatusLineChartPanel
#1178
+297
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
force-pushed
the
jcscotttiii/line-use-click
branch
from
9f37b24 to
fd32f8a
Compare
jcscottiii
force-pushed
the
jcscottiii/capture-gchart-click
branch
from
7363ed6 to
ea8053d
Compare
jcscottiii
force-pushed
the
jcscotttiii/line-use-click
branch
from
fd32f8a to
1bbac3a
Compare
jcscottiii
force-pushed
the
jcscottiii/capture-gchart-click
branch
from
ea8053d to
e19d966
Compare
jcscottiii
force-pushed
the
jcscotttiii/line-use-click
branch
from
1bbac3a to
c52894b
Compare
jrobbins
approved these changes
Feb 20, 2025
This PR builds upon the enhanced `webstatus-gchart` component (see related PR) by adding functionality to the `WebstatusLineChartPanel` abstract class to handle point selection and deselection events. This provides a consistent and customizable way for subclasses to react to user interactions with the chart. **Key changes:** * **`createPointSelectedTask` method:** This new method allows subclasses to define a `Task` to be executed when a point is selected on the chart. It also enables them to provide a `renderSuccess` function to render content based on the task's result. * **Event handling:** The `handlePointSelected` and `handlePointDeselected` methods handle the `point-selected` and `point-deselected` events dispatched by the `webstatus-gchart` component. * **State management:** The `_pointSelectedTask` and `_renderCustomPointSelectedSuccess` properties store the state associated with the selected point. * **Rendering:** The `renderPointSelectedDetails` method provides a placeholder for rendering details about the selected point, which can be customized by subclasses. * **Loading states:** The `renderPointSelectedDetails` method now includes loading states (pending, initial, error) to provide visual feedback during task execution. This enhancement enables subclasses of `WebstatusLineChartPanel` to easily handle point selection and deselection events, providing a more interactive and informative user experience. It leverages the new events introduced in the `webstatus-gchart` component (see related PR) to provide a seamless and consistent way to manage chart interactions.
jcscottiii
force-pushed
the
jcscotttiii/line-use-click
branch
from
c52894b to
41821d9
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful for this milestone: https://github.com/GoogleChrome/webstatus.dev/milestone/10
This PR builds upon the enhanced
webstatus-gchartcomponent (see related PR #1177 ) by adding functionality to theWebstatusLineChartPanelabstract class to handle point selection and deselection events. This provides a consistent and customizable way for subclasses to react to user interactions with the chart.Key changes:
createPointSelectedTaskmethod: This new method allows subclasses to define aTaskto be executed when a point is selected on the chart. It also enables them to provide arenderSuccessfunction to render content based on the task's result.handlePointSelectedandhandlePointDeselectedmethods handle thepoint-selectedandpoint-deselectedevents dispatched by thewebstatus-gchartcomponent._pointSelectedTaskand_renderCustomPointSelectedSuccessproperties store the state associated with the selected point.renderPointSelectedDetailsmethod provides a placeholder for rendering details about the selected point, which can be customized by subclasses.renderPointSelectedDetailsmethod now includes loading states (pending, initial, error) to provide visual feedback during task execution.This enhancement enables subclasses of
WebstatusLineChartPanelto easily handle point selection and deselection events, providing a more interactive and informative user experience. It leverages the new events introduced in thewebstatus-gchartcomponent (see related PR #1177) to provide a seamless and consistent way to manage chart interactions.