Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

feat: add youtube fallback styling #10040

Conversation

ShayPunter
Copy link
Contributor

@ShayPunter ShayPunter commented May 11, 2023

Fixes [#6193]GoogleChrome/developer.chrome.com#6193

Changes proposed in this pull request:

  • Implements some fallback styling for web.dev for youtube lite

How to test

  1. Clone webdev-infra and checkout branch 6193_youtube_embed_should_show_fallback_link
  2. Clone web.dev repository and checkout branch 6193_youtube_embed_should_show_fallback_when_js_is_disabled
  3. Setup a sym link between the webdev-infra and web.dev repository
  4. Navigate to /advancing-framework-ecosystem-cds-2019/ with javascript enabled, you should see the youtube video as expected
  5. Disable javascript
  6. Refresh the page, you should now see the fallback text in place of the youtube video

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for web-dev-staging ready!

Name Link
🔨 Latest commit bb126aa
🔍 Latest deploy log https://app.netlify.com/sites/web-dev-staging/deploys/645ce709bd6b5f0008b59b1d
😎 Deploy Preview https://deploy-preview-10040--web-dev-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ShayPunter ShayPunter marked this pull request as ready for review May 11, 2023 13:03
@stale
Copy link

stale bot commented Aug 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To prevent this from happening, leave a comment.

@stale stale bot added the stale label Aug 12, 2023
@devnook devnook closed this Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants