Skip to content

Fix flakey tests #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 20, 2025
Merged

Fix flakey tests #651

merged 4 commits into from
Nov 20, 2025
+2,757 −2,833

Conversation

@tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Nov 16, 2025 •
edited
Loading

  • CLS tests aren't reseting between tests causing CLS to grow.
  • Firefox has an INP bug causing problems with out tests
  • Firefox over emits LCP entries sent at the same time. Agreed at TPAC to change that.
  • Also seeing some deprecated messages in out error logs so updated some packages

philipwalton
philipwalton reviewed Nov 19, 2025
View reviewed changes
@tunetheweb tunetheweb merged commit 197f073 into main Nov 20, 2025
9 checks passed
@tunetheweb tunetheweb deleted the fix-tests branch November 20, 2025 07:14
@tunetheweb tunetheweb mentioned this pull request Nov 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philipwalton philipwalton philipwalton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tunetheweb @philipwalton