Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoAF Summary attribution information #574

Open
wants to merge 25 commits into
base: v5
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Document updates
tunetheweb committed Dec 10, 2024
commit dcd95df339250891718de8cdb7bc6d0a966a84f3
18 changes: 11 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
@@ -958,12 +958,16 @@ export interface LongAnimationFrameSummary {
*/
slowestScript?: slowestScriptSummary;
/**
* The total blocking durations in each phase by invoker for scripts that
* The total blocking durations in each sub-part by invoker for scripts that
* intersect the INP interaction.
*/
totalDurationsPerPhase?: Record<
'inputDelay' | 'processingDuration' | 'presentationDelay',
Record<ScriptInvokerType, number>
* For example:
* {
* 'inputDelay': { 'event-listener': 185, 'user-callback': 28},
* 'processingDuration': { 'event-listener': 144},
* }
*/
totalDurationsPerSubpart?: Partial<
Record<INPSubpart, Partial<Record<ScriptInvokerType, number>>>
>;
/**
* The total forced style and layout durations as provided by Long Animation
@@ -999,9 +1003,9 @@ export interface SlowestScriptSummary {
*/
entry: PerformanceScriptTiming;
/**
* The INP phase where the longest script ran.
* The INP sub-part where the longest script ran.
*/
phase: 'inputDelay' | 'processingDuration' | 'presentationDelay';
subpart: INPSubpart; //'inputDelay' | 'processingDuration' | 'presentationDelay';
/**
* The amount of time the slowest script intersected the INP duration.
*/
11 changes: 8 additions & 3 deletions src/types/inp.ts
Original file line number Diff line number Diff line change
@@ -41,9 +41,9 @@ export interface SlowestScriptSummary {
*/
entry: PerformanceScriptTiming;
/**
* The INP subpart where the longest script ran.
* The INP sub-part where the longest script ran.
*/
subpart: INPSubpart;
subpart: INPSubpart; //'inputDelay' | 'processingDuration' | 'presentationDelay';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
subpart: INPSubpart; //'inputDelay' | 'processingDuration' | 'presentationDelay';
subpart: INPSubpart; // 'input-delay' | 'processing-duration' | 'presentation-delay'

/**
* The amount of time the slowest script intersected the INP duration.
*/
@@ -127,8 +127,13 @@ export interface LongAnimationFrameSummary {
*/
slowestScript?: SlowestScriptSummary;
/**
* The total blocking durations in each subpart by invoker for scripts that
* The total blocking durations in each sub-part by invoker for scripts that
* intersect the INP interaction.
* For example:
* {
* 'inputDelay': { 'event-listener': 185, 'user-callback': 28},
* 'processingDuration': { 'event-listener': 144},
* }
*/
totalDurationsPerSubpart: Partial<
Record<INPSubpart, Partial<Record<ScriptInvokerType, number>>>