Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interoperable TTFB to measure Early Hints consistently #566

Open
wants to merge 13 commits into
base: v5
Choose a base branch
from

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Nov 7, 2024

Fixes #565

This will revert Chrome back to reporting TTFB as the Early Hints first bytes (same as other browsers and tools).

README.md Outdated Show resolved Hide resolved
@tunetheweb tunetheweb changed the title Add interoperable TTFB and documentDuration to measure Early Hints better Add interoperable TTFB to measure Early Hints consistently Nov 18, 2024
@GoogleChrome GoogleChrome deleted a comment from Montiwa11 Dec 10, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
src/attribution/onLCP.ts Outdated Show resolved Hide resolved
src/attribution/onLCP.ts Outdated Show resolved Hide resolved
src/onTTFB.ts Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
test/views/ttfb.njk Outdated Show resolved Hide resolved
@tunetheweb
Copy link
Member Author

@philipwalton WDYT about this one?

I know we agreed not to add a documentStart timeline (which has been removed from this PR) since that's easily getable by looking at finalHeadersResponseStart (about to be launched in Chrome 133), so we could not handle Chrome 115-133 differently since that's due to launch, but normally we try to support things for two years before we consider them no longer required to work around, so should we still merge this?

At the very least I think the Early Hints test is worth saving, but can move that to a separate PR. But it would need to wait for Chrome 133 to land if we don't merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants