Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Soft Navigation support #308

Draft
wants to merge 65 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
42ccabc
Initial LCP support
tunetheweb Jan 16, 2023
d995891
Add FCP support
tunetheweb Jan 16, 2023
d2fc3ec
Comments
tunetheweb Jan 16, 2023
9b8202d
Support buffered entries
tunetheweb Jan 17, 2023
d2e0ab6
Simplify LCP using performance.getEntriesByType() instead
tunetheweb Jan 19, 2023
97fd350
Bug fix
tunetheweb Jan 19, 2023
03f8448
Fix FCP too
tunetheweb Jan 19, 2023
74b1231
Linting
tunetheweb Jan 19, 2023
50e9ded
Add TTFB support
tunetheweb Jan 19, 2023
dca3482
README updates
tunetheweb Jan 19, 2023
a387712
Clean up Metric
tunetheweb Jan 19, 2023
50d8dc1
Add FID support
tunetheweb Jan 19, 2023
5fa268c
Tidy up
tunetheweb Jan 19, 2023
4f558ee
Add CLS
tunetheweb Jan 19, 2023
01ab0ed
Allow FID to show after hiding for soft navs
tunetheweb Jan 19, 2023
9e038c3
Implement CLS
tunetheweb Jan 19, 2023
d12ce69
Move from pageUrl to navigationId
tunetheweb Jan 20, 2023
9f87d85
Cleanup and fixes
tunetheweb Jan 20, 2023
1700428
Fix attribution
tunetheweb Jan 20, 2023
d0a4f19
Initial INP support
tunetheweb Jan 20, 2023
c5984e5
Finalize LCP on softnav change
tunetheweb Jan 20, 2023
9afc257
Switch LCP to process all entries so reportAllChanges works
tunetheweb Jan 20, 2023
7e316eb
Bug fixes
tunetheweb Jan 20, 2023
ecf82d4
Update package
tunetheweb Feb 3, 2023
f013531
Bump version number
tunetheweb Feb 8, 2023
2d7ea75
Fix onLCP for multiple callbacks
tunetheweb Feb 9, 2023
2e63c81
Update version
tunetheweb Feb 9, 2023
bb49653
Fix FID and FCP navigation type
tunetheweb Feb 9, 2023
60dde0b
Add support includeSoftNavigationObservations
tunetheweb Feb 10, 2023
aa45395
Update version
tunetheweb Feb 10, 2023
b4b28b0
Fix includeSoftNavigationObservations bug
tunetheweb Feb 11, 2023
f381326
Merge branch 'main' into soft-navs
tunetheweb Mar 6, 2023
e11c6b8
Merge branch 'main' into soft-navs
tunetheweb Mar 9, 2023
99d2b9b
Merge branch 'main' into soft-navs
tunetheweb Mar 9, 2023
5cdb8f9
Merge branch 'main' into soft-navs
tunetheweb Apr 4, 2023
090e7b2
Merge branch 'main' into soft-navs
tunetheweb May 29, 2023
39a043a
Merge branch 'main' into soft-navs
tunetheweb Jul 10, 2023
9c1e68c
Support navigationIds that are UUIDs
tunetheweb Jul 10, 2023
5cc8b86
UUID cleanup
tunetheweb Jul 10, 2023
94dd1cc
More clean up
tunetheweb Jul 10, 2023
f659c15
Avoid repeated soft nav lookups
tunetheweb Jul 10, 2023
607041f
More cleanup
tunetheweb Jul 10, 2023
db653ae
Cleanup and comments
tunetheweb Jul 10, 2023
173d87f
Even more cleanup and comments
tunetheweb Jul 11, 2023
71c5927
Fix comments
tunetheweb Jul 11, 2023
9d87a20
No INP unless supported by that browser
tunetheweb Jul 12, 2023
b39d261
Restore comment
tunetheweb Jul 12, 2023
9835574
Remove unnecessary ?
tunetheweb Jul 12, 2023
e373b67
Remove optional chaining
tunetheweb Jul 12, 2023
5de5e89
Merge branch 'main' into soft-navs
tunetheweb Sep 28, 2023
7c00038
Fix attribution for TTFB and LCP
tunetheweb Dec 13, 2023
2dea9a2
Fix FCP and LCP attributions
tunetheweb Dec 13, 2023
1e72319
Fix attribution of reused resource
tunetheweb Dec 13, 2023
42b8e47
Reset visibilitywatcher on soft nav
tunetheweb Dec 15, 2023
5b5c81c
Bump version number
tunetheweb Dec 15, 2023
1af7905
Merge branch 'main' into soft-navs
tunetheweb Dec 28, 2023
3ebf57f
Linting
tunetheweb Dec 28, 2023
5ab847d
Merge branch 'main' into soft-navs
tunetheweb Jan 26, 2024
8b8bd7f
Merge branch 'main' into soft-navs
tunetheweb Mar 19, 2024
44c6e07
Merge branch 'main' into soft-navs
tunetheweb Jul 31, 2024
cd5a2ee
Fix unit tests
tunetheweb Jul 31, 2024
f960498
Fix LCP on inputs for soft navs
tunetheweb Aug 1, 2024
57b751e
Bump version for npm publish
tunetheweb Aug 1, 2024
8a42838
Merge branch 'main' into soft-navs
tunetheweb Aug 4, 2024
a44dd93
Merge branch 'main' into soft-navs
tunetheweb Aug 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into soft-navs
tunetheweb committed Aug 4, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 8a428383115834df85463aaea58bbe8fe97c9b52
1 change: 1 addition & 0 deletions wdio.conf.cjs
Original file line number Diff line number Diff line change
@@ -82,6 +82,7 @@ module.exports.config = {
if (browserName === 'chrome') {
capability['goog:chromeOptions'] = {
excludeSwitches: ['enable-automation'],
// Can remove next line after puppeteer 21.2.1 lands
args: ['disable-search-engine-choice-screen'],
// Uncomment to test on Chrome Canary.
// binary: '/Applications/Google Chrome Canary.app/Contents/MacOS/Google Chrome Canary'
You are viewing a condensed version of this merge commit. You can view the full changes here.