Update web vitals (#168)

* [email protected] * [email protected] * pkg version
GoogleChrome · Jan 28, 2024 · 93a24b6 · 93a24b6
1 parent d676e39
commit 93a24b6
Show file tree

Hide file tree

Showing 6 changed files with 994 additions and 1,020 deletions.
diff --git a/manifest.json b/manifest.json
@@ -1,6 +1,6 @@
 {
   "name": "Web Vitals",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "manifest_version": 3,
   "description": "Measure metrics for a healthy site",
   "homepage_url": "https://web.dev/vitals/",

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "web-vitals-extension",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "Instant Web Vitals metrics",
   "main": "src/browser_action/vitals.js",
   "repository": "https://github.com/googlechrome/web-vitals-extension",
@@ -21,6 +21,6 @@
     "eslint-config-google": "^0.14.0"
   },
   "dependencies": {
-    "web-vitals": "^3.4.0"
+    "web-vitals": "^3.5.2"
   }
 }
diff --git a/src/browser_action/vitals.js b/src/browser_action/vitals.js
@@ -302,7 +302,15 @@
         metric.attribution.eventEntry) {
       const subPartString = `${metric.name} sub-part`;
       const eventEntry = metric.attribution.eventEntry;
-      console.log('Interaction target:', eventEntry.target);
+
+      let eventTarget = eventEntry.target;
+      // Sometimes the eventEntry has no target, so we need to hunt it out manually.
+      // As of [email protected] `attribution.eventTarget` does the same thing,
+      // but we want a reference to the element itself (for logging), not a selector.
+      if (!eventTarget) {
+        eventTarget = metric.entries.find(entry => entry.target)?.target;
+      }
+      console.log('Interaction target:', eventTarget);
 
       for (let entry of metric.entries) {
         console.log(`Interaction event type: %c${entry.name}`, 'font-family: monospace');

diff --git a/src/browser_action/web-vitals.js b/src/browser_action/web-vitals.js