Change FPS references to RWS references #87
Conversation
| @@ -32,7 +32,7 @@ jobs: | |||
| run: pip install publicsuffix2 | |||
| - name: Content check | |||
| id: check | |||
| run: python3 main/check_sites.py -i pull-request/first_party_sets.JSON --data_directory=main --with_diff > results.txt | |||
| run: python3 main/check_sites.py -i pull-request/related_website_sets.JSON --data_directory=main --with_diff > results.txt | |||
There was a problem hiding this comment.
This means that the workflow will be broken for this PR only, but should work afterward, right?
There was a problem hiding this comment.
Yeah, the current check is failing because it uses the main's version of the submission checks and is failing to find first-party-sets.json in this branch. Once this is merged, it shouldn't be a problem though.
There was a problem hiding this comment.
Right. Since there's another open PR, should we update the workflow so that it can handle either filename? Or are we planning on just asking the PR author to rebase and try again?
There was a problem hiding this comment.
It might be best to ask for the rebase. If we update the workflow and accept PRs with first-party-sets.JSON, we'd end up with 2 submission lists by accepting the PR and would have to resolve that ourselves, right?
There was a problem hiding this comment.
Actually, I think the checkout action will grab the latest version of main, instead of the parent commit of the PR branch. So no one would have to rebase, if we submit this as-is.
Readme.md was missed by [the renaming PR](#87), so its file references are now out of date. This PR updates those references to account for the FPS to RWS change.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
Now that the "First-Party Sets" project has been officially renamed to "Related Website Sets", references and filenames should be changed accordingly to refer to Related Websites rather than First-Parties.
Note: This PR should not be merged until the rest of the pipeline is prepared to handle the name change as well.
Additional note: This PR will fail the normal runs due to the change in various file names