Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more specific about expected schema validation failures #719

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

cfredric
Copy link
Collaborator

This ensures that validation fails for the right reason, i.e. that we're testing the thing that we intend to be testing.

@cfredric cfredric requested a review from sjledoux December 19, 2024 17:12
@cfredric cfredric self-assigned this Dec 19, 2024
Copy link

The RWS JSON was successfully validated!

THIS PR CONTAINS SYSTEM CHANGES PLEASE REVIEW WITH CARE!

Copy link
Collaborator

@sjledoux sjledoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjledoux sjledoux merged commit bc8a806 into GoogleChrome:main Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants