New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor error throwing from assertPageLoaded #2785

Merged

paulirish merged 2 commits into master from assertpageloadederrors

Jul 29, 2017

Member

paulirish commented Jul 28, 2017 •

edited

Loading

We say "timeout reached" even when no timeout was reached but the page failed for other reasons.

Discovered this when poking around #2784


          Refactor error throwing from assertPageLoaded

9e3cdfd

paulirish requested a review from patrickhulce

July 28, 2017 23:52

patrickhulce approved these changes

View reviewed changes


          test.

fbaef64

paulirish merged commit 07817f9 into master

paulirish deleted the assertpageloadederrors branch

July 29, 2017 00:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet