Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(ci): fix deprecated node usage in ci.yml #16095

Conversation

hamirmahal
Copy link
Contributor

Summary

This change makes it so that ci.yml doesn't use actions/setup-node@v3, which uses a deprecated version of Node.js.

Related Issues/PRs

This pull request fixes #16094.

@hamirmahal hamirmahal requested a review from a team as a code owner June 29, 2024 08:38
@hamirmahal hamirmahal requested review from connorjclark and removed request for a team June 29, 2024 08:38
@hamirmahal hamirmahal changed the title Fix/usage of deprecated actions ci yml misc(ci): fix deprecated node usage in ci.yml Jun 29, 2024
name: dist
path: dist/
- name: Upload dist
uses: actions/upload-artifact@v4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was using a version of actions/upload-artifact that is scheduled for deprecation, so I updated it to the latest major version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but can you get rid of all these other whitespace changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome, and sure; I removed the changes from formatting on save.

@connorjclark
Copy link
Collaborator

closing for #16191 (there's many usages of these things, so gotta update them all)

@hamirmahal hamirmahal deleted the fix/usage-of-deprecated-actions-ci-yml branch September 19, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci.yml uses a deprecated version of Node.js
3 participants