Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[devtools] Add devTools-tip video for CSS Grid #2143

Closed
wants to merge 3 commits into from
Closed

Conversation

jecfish
Copy link
Contributor

@jecfish jecfish commented Feb 18, 2022

No description provided.

@jecfish jecfish added the reviewers: devtools Enables code review by the DevTools team. label Feb 18, 2022
@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

site/en/docs/devtools/recorder/index.md

  • This file passed all of our automated Markdown audits.

@netlify
Copy link

netlify bot commented Feb 18, 2022

✔️ Deploy Preview for developer-chrome-com ready!

🔨 Explore the source changes: fa0d174

🔍 Inspect the deploy log: https://app.netlify.com/sites/developer-chrome-com/deploys/6214698edddb8700088a9313

😎 Browse the preview: https://deploy-preview-2143--developer-chrome-com.netlify.app

@jeffposnick
Copy link
Contributor

Sorry to detail this PR, but I'm curious whether there's been a discussion in place around tweaking our {% Video %} embed tag to prevent what might be a negative user experience.

Right now, with autoplay="true" set, visiting https://deploy-preview-2143--developer-chrome-com.netlify.app/docs/devtools/recorder/ will download the 17.2mb movie unconditionally, and it will start playing without user interaction. Also, note that you have muted="false" is set, but we force muted whenever autoplay is set, so there may be wasted bytes being transferred for an audio track that is never audible. (Unless the browser is smart enough not to download the audio track when muted is set?) In any case, it's good that it is muted, because I think many folks would be surprised to hear audio immediately after visiting a docs page.

I am new to d.c.c. and don't know the history behind the {% Video %} tag, so I'm going to move this discussion over to GoogleChrome/webdev-infra#24 to make it more formal. I don't want to stand in the way of this PR if it's important to get it merged, but I wanted to at least bring some visibility to the file size.

@jecfish
Copy link
Contributor Author

jecfish commented Feb 22, 2022

Close this PR as it is a mistake. It's an stale branch, not CSS Grid changes. The video has already been removed months ago and replaced with a YouTube video. See https://developer.chrome.com/docs/devtools/recorder/.

@jecfish jecfish closed this Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
reviewers: devtools Enables code review by the DevTools team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants