Fix permissions for management API #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent Chromium change [1] exposed the management API to the Chrome Web Store for testing purposes. Unfortunately, this meant chrome-types was thinking that the API was available without the `management` permission. Unfortunately, I couldn't see an easy way to fix this. To resolve that, I've made two tweaks here as workarounds: 1) Ignore feature definitions that are only for webpages. We don't really ever have a reason to show those in our documentation. 2) Teach the tool that if no channel is specified, this is equivalent to an API being available on stable. Together, these seem to be enough to cause the tool to filter out the wrong definitions and pick up the ones used by most developers. [1] https://source.chromium.org/chromium/chromium/src/+/59d0c94348743ce1831a113b81fd5dc420d68919:extensions/common/api/_api_features.json;dlc=30d48f6ef398e61601b43bcea809ac846fb99535
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 44.40% 44.47% +0.07%
==========================================
Files 21 21
Lines 4076 4085 +9
Branches 284 287 +3
==========================================
+ Hits 1810 1817 +7
- Misses 2266 2268 +2 ☔ View full report in Codecov by Sentry. |
oliverdunk
force-pushed
the
management-permissions-fix
branch
from
ab0ceb4 to
642c255
Compare
oliverdunk
force-pushed
the
management-permissions-fix
branch
from
642c255 to
3afa165
Compare
patrickkettner
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent Chromium change [1] exposed the management API to the Chrome Web Store for testing purposes. Unfortunately, this meant chrome-types was thinking that the API was available without the
managementpermission.Unfortunately, I couldn't see an easy way to fix this.
To resolve that, I've made two tweaks here as workarounds:
Ignore feature definitions that are only for webpages. We don't really ever have a reason to show those in our documentation.
Teach the tool that if no channel is specified, this is equivalent to an API being available on stable.
Together, these seem to be enough to cause the tool to filter out the wrong definitions and pick up the ones used by most developers.
[1] https://source.chromium.org/chromium/chromium/src/+/59d0c94348743ce1831a113b81fd5dc420d68919:extensions/common/api/_api_features.json;dlc=30d48f6ef398e61601b43bcea809ac846fb99535