Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct condition for openPopup() API #75

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

oliverdunk
Copy link
Member

Really hoping this is the last one - the build is passing now, but since I'm using >= we want Chrome 127 here to show the correct availability :)

@oliverdunk oliverdunk requested a review from patrickkettner June 6, 2024 14:06
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.40%. Comparing base (5cdcf00) to head (8b004e5).
Report is 2 commits behind head on main.

Files Patch % Lines
tools/override.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   44.40%   44.40%           
=======================================
  Files          21       21           
  Lines        4076     4076           
  Branches      284      284           
=======================================
  Hits         1810     1810           
  Misses       2266     2266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliverdunk oliverdunk merged commit 5659a0b into main Jun 18, 2024
5 of 6 checks passed
@oliverdunk oliverdunk deleted the openpopup-condition branch June 18, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant