Adjust visibility for action.openPopup API #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API was available for policy installed extensions in earlier versions of Chrome. However, hide the API in these versions so we use the general availability version in our documentation.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 44.28% 44.31% +0.02%
==========================================
Files 21 21
Lines 4067 4069 +2
Branches 282 282
==========================================
+ Hits 1801 1803 +2
Misses 2266 2266 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API was available for policy installed extensions in earlier versions of Chrome. However, hide the API in these versions when calculating history data. This means it will show as 127+ in our documentation, rather than 118+.
I'm going to open a corresponding Chromium CL so we also have a string documenting the policy availability in earlier versions.