Settings #1
Open
Settings #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not shown at tech cards when there is none.
|
|
||
| function changeTheme(toTheme) { | ||
| let fromTheme; | ||
| toTheme == 'light' ? fromTheme = 'dark' : fromTheme = 'light' |
There was a problem hiding this comment.
una asignación con el ternary operator se suele hacer así:
fromTheme = toTheme == 'light' ? 'dark' : 'light'
| const premierePro = new Hardskill ('Premiere Pro', 5, ['None']); | ||
| const blender = new Hardskill ('Blender', 5, ['None']); | ||
|
|
||
| const hardSkills = [ |
There was a problem hiding this comment.
para evitar hacer el find abajo esto podría ser un dict, donde las keys sean los names de las Hardskill:
html5.name: html5
después abajo haces:
let reqTech = hardSkills[techName];
| </div> | ||
| `; | ||
|
|
||
| if (mentionContent == 'None') { |
There was a problem hiding this comment.
esto quizá quede más limpio si pones lista vacía en las hardskill.related en lugar de None, ejemplo:
const react = new Hardskill ('React JS', 1, []);
y después haces:
if (reqTech.related.length == 0) { ... }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.