Skip to content

Add request data #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

vincentrolfs
Copy link

@vincentrolfs vincentrolfs commented Jul 29, 2020

  • Remove call to Bootstrap::exceptionHandler and do the boilerplate work ourselves in order to be able to send more data to error reporting
  • Send the following data to error reporting (in addition to what we have always sent):
    • User id
    • Request URL
    • Request method (GET, POST, ...)
    • User agent
    • Referrer URL
    • Client IP
  • Enable users to supply additional context data as they wish

…k ourselves in order to be able to send more data to error reporting. Enable users to supply additional context data as they wish.
@vincentrolfs
Copy link
Author

Things to note:

  • I am not sure if it could be a problem with GDPR that we are automatically logging user id, user agent and client IP on error. Maybe this should be opt-in.
  • I had to copy some code from Google\Cloud\ErrorReporting\Bootstrap which was private static. This code is licensed under Apache 2.0 which is different from our license (MIT). Not sure what the implications of this are.

@DiederikvandenB
Copy link
Contributor

Hi, I am sorry, this slipped off my radar.

I indeed do think that adding user data is a bit tricky given GDPR. I think we better make this opt-in.
Having checked the Apache 2.0 license, I don't think we'll have any issues here including that code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants