-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytest upgrade from pytest 3 to pytest 6 #3
base: main
Are you sure you want to change the base?
Pytest upgrade from pytest 3 to pytest 6 #3
Conversation
This reverts commit 857f30a.
…thub.com/tking16/pytest-appium into pytest-upgrade-from-pytest-3-to-pytest-6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of relatively minor comments
Given this is public it might also be worth:
- Tagging the current version in git
- Updating the version number for this new version and tagging it
**/.vscode | ||
|
||
.pytest_appium.egg-info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably just make this *.egg-info tbh
def get_json(url): | ||
return _decode_response(urllib.request.urlopen(url)) | ||
def get_json(url, headers: dict=None): | ||
r = requests.get(url, headers=headers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for not also updating the post if we're swapping urlib for requests?
No description provided.