Request range to determine seekability #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-kokoev-global
approved these changes
Dec 16, 2022
trafico-bot
bot
added
✅ Approved
Jackstone92
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unhappy with my previous PR and wanted to do more digging into when an audio file is seekable. Most other players (like JWPlayer we use on GP.com) initially sent a
Range=0-1request to force a response from the server side. It returns either a 206 (Partial content), which means it is seekable or 200 with a possibleAccept-Ranges=nonewhich means it is not.For example, VLC follows a similar logic where it determines seekability based on 206 status code.