Replace libz-rs-sys FFI wrapper with direct zlib-rs usage #2298
+75
−98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates FFI layer by using
zlib-rsdirectly instead of its C-compatible wrapperlibz-rs-sys. The underlying implementation is identical; this removes an unnecessary indirection layer.Changes
Dependency update (
gix-features/Cargo.toml):libz-rs-sys→zlib-rsAPI migration (
gix-features/src/zlib/):libz_rs_sys::inflateInit_()→zlib_rs::inflate::init()libz_rs_sys::inflate()→zlib_rs::inflate::inflate()libz_rs_sys::deflate()→zlib_rs::deflate::deflate()reset()andend()functionsSafety boundary:
unsaferemains only forz_stream↔ typed stream conversionsSend/Syncimpls and safety commentsExample
Note:
deflate()is fully safe;inflate()remainsunsafein zlib-rs API due to output buffer handling.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.