add committer fallback for fetch #2048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphmodales
force-pushed
the
fetch-without-commiter-config
branch
from
e5a734f to
62e4bab
Compare
|
Thanks a lot! |
That way one can always obtain a committer, even though it might not represent the entity actually committing.
Byron
force-pushed
the
fetch-without-commiter-config
branch
from
615ff19 to
d7db360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2040
This PR extends the existing committer fallback logic from clone operation to fetch operation. When no committer is configured, fetch now uses the same dummy values as the clone.